Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: add subclass and null prototype support for errors in inspect #26923

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Mar 26, 2019

This adds support to visualize the difference between errors with
null prototype or subclassed errors. This has a couple safeguards
to be sure that the output is not intrusive.

We normally handle changed util.inspect() output as semver-patch
but in this case I'd say it's more like a semver-major even though I'd
love to get some early feedback. Any opinions about this?

CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1778/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This adds support to visualize the difference between errors with
null prototype or subclassed errors. This has a couple safeguards
to be sure that the output is not intrusive.
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Mar 26, 2019
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 26, 2019
@BridgeAR
Copy link
Member Author

@targos @jasnell do you have an opinion about the semverness of this PR?

CITGM master https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1782/
CITGM PR https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1784/

@jasnell
Copy link
Member

jasnell commented Mar 29, 2019

No opinion on it really. I trust your judgement on it

@targos
Copy link
Member

targos commented Mar 29, 2019

Same

@targos
Copy link
Member

targos commented Mar 30, 2019

Landed in e54f237

@targos targos closed this Mar 30, 2019
targos pushed a commit that referenced this pull request Mar 30, 2019
This adds support to visualize the difference between errors with
null prototype or subclassed errors. This has a couple safeguards
to be sure that the output is not intrusive.

PR-URL: #26923
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR
Copy link
Member Author

I added the do not land labels on this for v6-v10.

BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
This adds support to visualize the difference between errors with
null prototype or subclassed errors. This has a couple safeguards
to be sure that the output is not intrusive.

PR-URL: #26923
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
This adds support to visualize the difference between errors with
null prototype or subclassed errors. This has a couple safeguards
to be sure that the output is not intrusive.

PR-URL: #26923
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
@BridgeAR BridgeAR deleted the improve-error-inspection-2 branch January 20, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants